Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtorc: cleanup init db handling #17198

Merged
merged 3 commits into from
Nov 26, 2024
Merged

vtorc: cleanup init db handling #17198

merged 3 commits into from
Nov 26, 2024

Conversation

timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Nov 9, 2024 •
edited
Loading

Description

This PR does some cleanup to the way errors are handled in vtorc at DB init-time, some details:

  • Funcs with unused error return now check return
  • log.Fatal(...)s move to the top level caller

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
vtorc: cleanup init db handling
0ba72f2 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt added Type: Internal Cleanup Component: VTorc Vitess Orchestrator integration labels Nov 9, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 9, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Nov 9, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (69b381f) to head (26937a8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/db/db.go 36.84% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17198      +/-   ##
==========================================
+ Coverage   67.40%   67.41%   +0.01%     
==========================================
  Files        1573     1573              
  Lines      253181   253184       +3     
==========================================
+ Hits       170645   170676      +31     
+ Misses      82536    82508      -28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timvaillancourt timvaillancourt marked this pull request as ready for review November 10, 2024 01:36
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 10, 2024
@shlomi-noach
Copy link
Contributor

@timvaillancourt this now shows conflicts having merged #17154

@GuptaManan100 GuptaManan100 merged commit 8648264 into vitessio:main Nov 26, 2024
99 checks passed
jwangace pushed a commit to jwangace/vitess that referenced this pull request Nov 27, 2024
@timvaillancourt @GuptaManan100
vtorc: cleanup init db handling (vitessio#17198)
f1e8c09 
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Signed-off-by: Jun Wang <[email protected]>
@timvaillancourt timvaillancourt deleted the vtorc-init-err-cleanup branch November 27, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @shlomi-noach @GuptaManan100